From: Aditya Garg <gargaditya08@live.com>
Date: Thu, 08 May 2025 10:38:06 GMT
Subject: Re: [PATCH v4 1/3] send-mail: improve checks for valid_fqdn
Message-ID: <PN3PR01MB9597B28DEE072C9D452EDB68B88BA@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
In-Reply-To: <xmqqzffo9h6v.fsf@gitster.g>

> Yuck, can we do something about this overly long mess?  
> 
> If use a temporary $subdomain = '(?!-)[A-Za-z0-9-]{1,63}(?<!-)',
> would it make it easier to spot the repetition in the structure,
> i.e. /^$subdomain(?:\.$subdomain)*$/ and make it less error prone
> when somebody has to touch lines around here, or something?
> 
> But other than that, looking good.
> 
> Even though this allows "foo.local", on "darwin" it is still not
> allowed, which sounds like a regression-free change

Sent a version 5 here: https://lore.kernel.org/git/PN3PR01MB95974932FF37D9F24A7633C6B88BA@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM/T/#t

I forgot to add --in-reply-to while using git send-email to send v5, so it got sent
as a separate thread by mistake.