From: Aditya Garg <gargaditya08@live.com>
Date: Mon, 26 May 2025 15:54:16 GMT
Subject: Re: [PATCH v3 1/2] send-email: fix bug resulting in increased message number if a message is edited
Message-ID: <PN3PR01MB95973C8CEC731B43816AB38CB865A@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
In-Reply-To: <7f5b2891-262f-48e7-9c29-7f3265abd07a@app.fastmail.com>



On 26/05/25 12:19 am, Kristoffer Haugsbakk wrote:
> Hi
> 
>> send-email: fix bug resulting in increased message number if a message is edited
> 
> I don’t understand what the bug is from the title.  “Message number”
> sounds harmless.  It breaks the threading?  The summary/subject could
> say that instead.  Fix threading bug.
> 
> On Sun, May 25, 2025, at 19:12, Aditya Garg wrote:
>> In case a message is edited before it is sent, its message number gets
>> increased by 1, and so does its order in the message id.
> 
> It feels like this part about increasing by one and if-editing gets
> repeated at least two times in this paragraph.
> 
>> The cause of this bug was that when a person attempts to edit the
>> message, the whole sub process_file gets terminated, and the user is
>> asked to edit the message.
> 
> Here’s the repetition.
> 
> Also I am not familiar with the code.  Just testing it I get this `6` here:
> 
>     Message-ID: <20250525181003.40129-6-kristofferhaugsbakk@fastmail.com>
> 
> Which was incremented every time I did an edit with:
> 
>     send-email --suppress-cc=all --to=<me> \
>         --confirm=always one two
> 

I have re-written the whole message again, but forgot to --in-reply-to this
thread :(

https://lore.kernel.org/git/cover.1748274404.git.gargaditya08@live.com/T/#t
should have the v4.