From: Aditya Garg <gargaditya08@live.com>
Date: Sat, 31 May 2025 09:06:39 GMT
Subject: Re: [PATCH v9 2/9] imap-send: add support for OAuth2.0 authentication
Message-ID: <PN3PR01MB95972787839A31A0152A16ABB860A@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
In-Reply-To: <xmqqfrglerbx.fsf@gitster.g>



> On 31 May 2025, at 2:42 AM, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Eric Sunshine <sunshine@sunshineco.com> writes:
> 
>> Not a proper review, just something I spotted several versions back
>> but assumed that someone else -- providing a proper review -- would
>> mention...
> 
> I suspect that we weren't ready to prifvide "a proper review" yet on
> this series at the coding style level, while the design at a bit
> higher level, like "should choice of openssl/curl be runtime?", was
> discussed.

I think that has been made clear. Just leave it as it is right now and
drop the patch allowing user to set it using the config.