From: Ben Peart <ben.peart@microsoft.com>
Date: Sat, 23 Sep 2017 23:33:00 GMT
Subject: RE: [PATCH v8 08/12] fsmonitor: add a test tool to dump the index extension
Message-ID: <MWHPR21MB0478265059A957CFB8785CEFF4640@MWHPR21MB0478.namprd21.prod.outlook.com>
In-Reply-To: <20170922233707.25414-2-martin.agren@gmail.com>

> -----Original Message-----
> From: Martin Ågren [mailto:martin.agren@gmail.com]
> Sent: Friday, September 22, 2017 7:37 PM
> To: Ben Peart <Ben.Peart@microsoft.com>
> Cc: David Turner <David.Turner@twosigma.com>; Ævar Arnfjörð Bjarmason
> <avarab@gmail.com>; Christian Couder <christian.couder@gmail.com>;
> git@vger.kernel.org; Junio C Hamano <gitster@pobox.com>; Johannes
> Schindelin <johannes.schindelin@gmx.de>; Nguyễn Thái Ngọc Duy
> <pclouds@gmail.com>; Jeff King <peff@peff.net>
> Subject: Re: [PATCH v8 08/12] fsmonitor: add a test tool to dump the index
> extension
> 
> On 22 September 2017 at 18:35, Ben Peart <benpeart@microsoft.com>
> wrote:
> > Add a test utility (test-dump-fsmonitor) that will dump the fsmonitor
> > index extension.
> >
> > Signed-off-by: Ben Peart <benpeart@microsoft.com>
> > ---
> >  Makefile                       |  1 +
> >  t/helper/test-dump-fsmonitor.c | 21 +++++++++++++++++++++
> >  2 files changed, 22 insertions(+)
> >  create mode 100644 t/helper/test-dump-fsmonitor.c
> 
> You forget to add the new binary to .gitignore. (In patch 12/12, you introduce
> test-drop-caches, which you _do_ add to .gitignore.)
> 

Oops.  Thanks!  Hopefully Junio can squash this in...

> Martin
> 
> diff --git a/t/helper/.gitignore b/t/helper/.gitignore index
> 6f07de62d..0fe2e0440 100644
> --- a/t/helper/.gitignore
> +++ b/t/helper/.gitignore
> @@ -6,6 +6,7 @@
>  /test-delta
>  /test-drop-caches
>  /test-dump-cache-tree
> +/test-dump-fsmonitor
>  /test-dump-split-index
>  /test-dump-untracked-cache
>  /test-fake-ssh
> --
> 2.14.1.727.g9ddaf86