From: Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil>
Date: Tue, 15 Jun 2010 15:19:02 GMT
Subject: Re: [PATCH next] test-lib: set $DIFF to diff if it is unset
Message-ID: <MTKWrx_yfsJOdxAp5oH0FEOHFEBrkTzK1kWr_OkbndT_557CMkCAHA@cipher.nrlssc.navy.mil>
In-Reply-To: <iUCxSq8AkQcB-kKuhJbfBTktKHW01RLx8KAu4BZwAUKZkkBhiPlxTg@cipher.nrlssc.navy.mil>

On 06/11/2010 11:26 AM, Brandon Casey wrote:
> On 06/11/2010 11:15 AM, Junio C Hamano wrote:
>> Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil> writes:
>>
>>> I think what should be done instead, is to move this section
>>> down below the line where GIT-BUILD-OPTIONS is sourced.  That
>>> way, the value of $DIFF can be gotten from that file.
>>>
>>> I guess GIT_TEST_CMP and GIT_TEST_CMP_USE_COPIED_CONTEXT
>>> should be written into GIT-BUILD-OPTIONS too.
>> I like that.  Something like this?
> 
> Looks good, will test.

Works for me.  It's kind of belated, I know.