From: Hamza Mahfooz <someguy@effective-light.com>
Date: Tue, 21 Sep 2021 02:38:10 GMT
Subject: Re: [PATCH v6 2/2] pretty: colorize pattern matches in commit messages
Message-ID: <MBJRZQ.9003XUH26Y7G2@effective-light.com>
In-Reply-To: <YUk3zwuse56v76ze@coredump.intra.peff.net>


On Mon, Sep 20 2021 at 09:39:27 PM -0400, Jeff King <peff@peff.net> 
wrote:
> Here are two patches I prepared on top of your series to show what's
> possible, though I think we should do one of:
> 
>   - put them at the front of your series (with the appropriate
>     adjustments) as preparatory cleanup
> 
>   - keep them separate. You can put a comment above the cast to 
> mention
>     what's going on and why it's OK for now, and then later when 
> they're
>     both merged, we can remove that cast.

Option 1 is preferable from my perspective, in that case.