From: Caleb White Date: Sun, 06 Oct 2024 22:37:10 GMT Subject: Re: [PATCH v2 2/4] worktree: link worktrees with relative paths Message-ID: In-Reply-To: On Sunday, October 6th, 2024 at 06:05, Eric Sunshine wrote: > When you reroll, please extend the commit message to give a more > detailed overview of how this patch actually changes the behavior both > at a high level and at a low level. This is especially important since > this patch is sufficiently long and involved that it's not easy to > glean these details at-a-glance from the code changes themselves. I will do that, I was not sure how much low level detail I should dive into. > Regarding what you wrote above, there seems to be a good deal of > redundancy between the first two paragraphs; combining the paragraphs > and folding out the duplication might make the message more > streamlined. I do like the discussion about containerized environments > being used as (at least one) justification for employing relative > paths, and think that may be a good lead-in for the commit message. > Please see [1] for some helpful hints for composing a good commit > message. Thanks, I will clean up the redundancy and add more detail to the commit.