From: Wincent Colaiuta Date: Tue, 19 Feb 2008 00:23:04 GMT Subject: Re: gitweb bug: broken "next" and other links Message-ID: In-Reply-To: <200802190032.36712.jnareb@gmail.com> El 19/2/2008, a las 0:32, Jakub Narebski escribió: > Dnia niedziela 17. lutego 2008 11:51, Wincent Colaiuta napisał: >> El 15/2/2008, a las 22:16, Jakub Narebski escribió: >>> >>> WORKSFORME. I could not reproduce this error with the patch >>> below applied. I think that the previous version of patch should >>> give the same result; should also fix this bug. >>> >>> Besides, both "next" and "raw" links are generated using the same >>> mechanism. It would be strange if one of them broke and other >>> didn't. >> >> Just re-tested again, this time applying on top of 1.5.4.2 and >> definitely doesn't work for me. >> >> The "next" links are fixed, the "raw" links still exhibit the same >> problem. >> >> eg. here's a commitdiff page with a broken "raw" link from my >> installation: >> >> http://git.wincent.com/wikitext.git?a=commitdiff;h=03b8fda6594aa7e6fab3b95b66a4f3c178d6a156 >> >> And here's a shortlog page with now-working "next" links: >> >> http://git.wincent.com/wikitext.git?a=shortlog;h=03b8fda6594aa7e6fab3b95b66a4f3c178d6a156 > > Could you reproduce this error with git.git repository (after any of > the two patches, but please tell which)? Please provide an URL to the > page, and fragment of HTML with wrong link. > > BTW. I have just checked above link, and the "raw" link is most > certainly not broken. Were you using updated gitweb (with patch), > and reloaded page? Well I'll be darned. Looks like my browser (Safari) was showing me an older version of the commitdiff page. Crazy browser. I had confirmed that both links were not working, then applied your patch, then reloaded both pages (or so I thought) and saw that the commitdiff page was still broken. I went through this cycle at least twice (once when you first the patch, and again days later when I reapplied and retested) and both times got the same results. But now having left the server alone (patch still applied) I revisit the link and you're right: it works. Sorry for the confusion and thanks for fixing the bug. Darn browser. Cheers, Wincent