From: Andy Lester Date: Wed, 22 Apr 2009 19:06:22 GMT Subject: Re: Removing duplicated code between builtin-send-pack.c and transport.c Message-ID: In-Reply-To: <20090422190337.GA13424@coredump.intra.peff.net> On Apr 22, 2009, at 2:03 PM, Jeff King wrote: > I think Andy was referring to (2), and I think that should be cleaned > up, as the different versions have a tendency to diverge. Probably > addressing (1) by moving send_pack() to transport.c makes sense as > part > of the same cleanup. Yes, exactly. I was applying const to function parameters in builtin- send-pack.c, and discovered the duplication. I sure don't want to patch twice if we don't need to. So it sounds like what I'll do is start a send-pack.c and hoist out the common functions from builtin-send-pack.c and transport.c. xoxo, Andy -- Andy Lester => andy@petdance.com => www.theworkinggeek.com => AIM:petdance