From: Kyle J. McKay <mackyle@gmail.com>
Date: Wed, 24 Jul 2013 19:35:50 GMT
Subject: Re: [PATCH] test-url-normalize.c: Fix gcc errors and sparse warnings
Message-ID: <FDCB9C95-34A7-45D8-AC23-9739C24043B5@gmail.com>
In-Reply-To: <51F0260B.5000905@ramsay1.demon.co.uk>

On Jul 24, 2013, at 12:07, Ramsay Jones wrote:

>
> Sparse issues an "non-ANSI function declaration of function 'main'"
> warning when NO_CURL is set. In order to suppress the warning, we
> simply add the function prototype.
>
> When NO_CURL and USE_CURL_MULTI are not defined, then gcc issues the
> following error:
>
>      CC test-url-normalize.o
>  test-url-normalize.c: In function `run_http_options':
>  test-url-normalize.c:49: error: `max_requests' undeclared (first  
> use in this function)
>  test-url-normalize.c:49: error: (Each undeclared identifier is  
> reported only once
>  test-url-normalize.c:49: error: for each function it appears in.)
>  make: *** [test-url-normalize.o] Error 1
>
> In order to fix the error, we simply protect the use of the  
> 'max_requests'
> variable with an preprocessor conditional.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Hi Kyle,
>
> When you next update the patches in your 'km/http-curl-config-per-url'
> branch, could you please squash this (or something like it) into the
> relevant patches.
>
> Thanks!
>
> ATB,
> Ramsay Jones

Thanks.

And hopefully Junio can add this as an incremental patch against next  
as it looks good to me.