From: Steffen Prohaska <prohaska@zib.de>
Date: Wed, 02 Jul 2008 14:04:33 GMT
Subject: Re: [PATCH 02/12] Do not complain about "no common commits" in an empty repo
Message-ID: <FCE9D8BE-BA1A-46D1-AC45-2DC4E419DE8E@zib.de>
In-Reply-To: <7vskusd5nr.fsf@gitster.siamese.dyndns.org>


On Jul 2, 2008, at 10:58 AM, Junio C Hamano wrote:

> Steffen Prohaska <prohaska@zib.de> writes:
>
>> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>>
>> If the repo is empty, we know that already, thank you very much.
>> So shut fetch-pack up about that case.
>
> Two complaints.

You are right, although I didn't intend to "hide" the patch.  I just
went through the differences between the mainline and 4msysgit and
collected a patch series with all changes I found.  I sent this series
to the list, so that the remaining differences do not get lost
unrecognized.

I didn't mean to bother you with incomplete patches.  Maybe I should
have made my intention clearer by prefixing the subject lines with
WIP (or something similar).  Apologies.


> * What does this have to do with Windows port?  Please don't hide a
>   general interface change in a larger and mostly unrelated topic.

I remember that users of msysgit's net installer complaint about this
warning.  The warning appeared as part of the output of a sequence of
automatically executed commands.  Without context, the users did not
understand what the warning means.


> * Do you think people can tell without reading the code in larger  
> context
>   outside the patch and this commit log text if you are talking  
> about the
>   case you fetch _into_ an empty repository, or if you are  
> attempting to
>   fetch _from_ an empty repository, or what?  Please try to be a bit
>   easier for _readers_.  Being more redundant and verbose is better  
> than
>   being too concise.
>
> About the first point, "no common commits" is just a friendly  
> reminder and
> not even an error.  When you see it, you will learn to expect  
> looooooooong
> download session.
>
> I personally happen to agree with the logic of this patch, though  
> --- if
> you are fetching into an empty repository, you would already expect  
> that
> the download is as big as the other end anyway, so you would not  
> need to
> be further reminded about that.
>
> But that is just one-man's opinion.  Maybe somebody knows a reason  
> why I
> am (and the logic I am agreeing with is) wrong.  Maybe not.  So make  
> the
> "remainder of Windows port" series 11 commits, and send this as a  
> general
> interface fix via the normal channel to be discussed, please.


Dscho, will you send it?  You are the original author.
	
	Steffen