From: Steffen Prohaska Date: Mon, 25 Feb 2008 23:34:56 GMT Subject: Re: [PATCH] Add tests for filesystem challenges (case and unicode normalization) Message-ID: In-Reply-To: <7voda4hikx.fsf@gitster.siamese.dyndns.org> On Feb 25, 2008, at 9:44 PM, Junio C Hamano wrote: > Steffen Prohaska writes: > >> Unfortunately, I had no time to start the real work of fixing the >> issues that are tested below. > > That's fine. We are not in a hurry. Well, I am, ... kind of. git constantly stumbles over a filename whose case changed. But fortunately I do not need to wait much longer until history will eventually have grown sufficiently such that the rename will no longer surface ;-) >> But at least the tests should be in >> good shape now and could be applied. > > I do not think we would want to see "FIXED" on systems that > already behave sanely, so we would want a fix-up like this on > top of your patch, and it would be a good to go. > > I do not have a handy way to test this, though, so can you try > it out and make sure test_case and test_unicode are set to > test_expect_failure correctly on problematic filesystems? This is a sensible way of handling this. It works for me, except for ... > -- > > t/t0050-filesystem.sh | 38 ++++++++++++++++++++++++++++++++------ > 1 files changed, 32 insertions(+), 6 deletions(-) > > diff --git a/t/t0050-filesystem.sh b/t/t0050-filesystem.sh > index a0ab02e..b395c22 100755 > --- a/t/t0050-filesystem.sh > +++ b/t/t0050-filesystem.sh > @@ -4,6 +4,34 @@ test_description='Various filesystem issues' > > . ./test-lib.sh > > +auml=`perl -CO -e 'print pack("U",0x00E4)'` > +aumlcdiar=`perl -CO -e 'print pack("U",0x0061).pack("U",0x0308)'` > + > +test_expect_success 'see if we expect ' ' > + > + test_case=test_expect_success > + test_unicode=test_expect_success > + mkdir junk && > + echo good >junk/CamelCase && > + echo bad >junk/camelcase && > + if test "$(cat junk/CamelCase)" != good > + then > + test_camel=test_expect_failure test_case (instead of test_camel). Steffen