From: Lars Schneider <larsxschneider@gmail.com>
Date: Wed, 07 Mar 2018 22:58:58 GMT
Subject: Re: [PATCH v10 9/9] convert: add round trip check based on 'core.checkRoundtripEncoding'
Message-ID: <F974DE28-D4EE-4BC6-9AE8-BF5F79FACC86@gmail.com>
In-Reply-To: <xmqqzi3jxzus.fsf@gitster-ct.c.googlers.com>


> On 07 Mar 2018, at 23:52, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Lars Schneider <larsxschneider@gmail.com> writes:
> 
>> I don't think HT makes too much sense. However, isspace() is nice
>> and I will use it. Being more permissive on the inputs should hurt.
> 
> You are being incoherent in these three sentences.  If you want to
> be more strict and only allow SP, then isspace() is already too
> broad, as it does allow HT (and even CR and LF).

I meant "Being more permissive on the inputs shouldN'T hurt." :-)


> I do think HT makes just as much sense as SP, though, so if you use
> isspace(), that would be perfectly fine.

OK!

- Lars