From: David Turner <novalis@novalis.org>
Date: Mon, 17 Dec 2018 22:34:33 GMT
Subject: Re: [PATCH] upload-pack: turn on uploadpack.allowAnySHA1InWant=true
Message-ID: <F368D768-7DC6-479C-8888-2A41360B0B6A@novalis.org>
In-Reply-To: <20181217221625.1523-1-avarab@gmail.com>

Overall, I like this. One nit:

On December 17, 2018 5:16:25 PM EST, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com> wrote:
>--- a/upload-pack.c
>+++ b/upload-pack.c
>@@ -54,7 +54,8 @@ static int no_progress, daemon_mode;
> #define ALLOW_REACHABLE_SHA1	02
>/* Allow request of any sha1. Implies ALLOW_TIP_SHA1 and
>ALLOW_REACHABLE_SHA1. */
> #define ALLOW_ANY_SHA1	07
>-static unsigned int allow_unadvertised_object_request;
>+static unsigned int allow_unadvertised_object_request = (
>+	ALLOW_TIP_SHA1 | ALLOW_REACHABLE_SHA1 | ALLOW_ANY_SHA1);

ALLOW_ANY_SHA1 already includes the other two.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.