From: Lars Schneider <larsxschneider@gmail.com>
Date: Thu, 25 Aug 2016 18:47:30 GMT
Subject: Re: [PATCH v6 03/13] pkt-line: add packet_write_fmt_gently()
Message-ID: <EEB25464-5EBC-4CAE-A104-2896290A1E06@gmail.com>
In-Reply-To: <CAGZ79kbEoYVM_+MWkajT2pHN1OKZXATe5d+Dv_uSJ7dyPGxUeg@mail.gmail.com>

On 25 Aug 2016, at 20:12, Stefan Beller <sbeller@google.com> wrote:

>> +int packet_write_fmt_gently(int fd, const char *fmt, ...)
>> +{
>> +       static struct strbuf buf = STRBUF_INIT;
>> +       va_list args;
>> +
>> +       strbuf_reset(&buf);
>> +       va_start(args, fmt);
>> +       format_packet(&buf, fmt, args);
> 
> format_packet also takes care of tracing the contents,
> which was a bit unexpected to me.

To me, too :)
http://public-inbox.org/git/20160810143321.q7mjirgr5ynml5ff@sigill.intra.peff.net/

The series is already pretty large and therefore I decided to leave this as-is.

> Do we also want to trace failure?

You mean in all new *_gently() functions? Good idea!

Thanks,
Lars