From: Philip Oakley Date: Sun, 03 Mar 2013 23:44:18 GMT Subject: Re: [PATCH v2 2/5] Help.c use OPT_COUNTUP Message-ID: In-Reply-To: <7vwqtoyryp.fsf@alter.siamese.dyndns.org> [Sorry if the resend with Cc: crossed over] From: "Junio C Hamano" Sent: Sunday, March 03, 2013 11:38 PM Subject: Re: [PATCH v2 2/5] Help.c use OPT_COUNTUP > Philip Oakley writes: > >> rename deprecated option in preparation for 'git help --guides'. > > s/rename/Rename/; OK. > >> >> Signed-off-by: Philip Oakley >> --- > > Hrm, I do not recall anybody ever declared that "--all" is deprecated. No, it was the use OPT_COUNTUP rather than OPT_BOOLEAN that the 'deprecated' was refering to. Maybe be I should have extended what option was being refered to. > > I do not think we want --all and --all --all to be different, and we > certainly do not want --all --no-all to be not-all, so I cannot tell > what you want to achieve with this change at all, either from the > patch or the proposed log message. > >> builtin/help.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/builtin/help.c b/builtin/help.c >> index d1d7181..d10cbed 100644 >> --- a/builtin/help.c >> +++ b/builtin/help.c >> @@ -39,7 +39,7 @@ static int show_all = 0; >> static unsigned int colopts; >> static enum help_format help_format = HELP_FORMAT_NONE; >> static struct option builtin_help_options[] = { >> - OPT_BOOLEAN('a', "all", &show_all, N_("print all available >> commands")), >> + OPT_COUNTUP('a', "all", &show_all, N_("print all available >> commands")), >> OPT_SET_INT('m', "man", &help_format, N_("show man page"), >> HELP_FORMAT_MAN), >> OPT_SET_INT('w', "web", &help_format, N_("show manual in web >> browser"), >> HELP_FORMAT_WEB),