From: Lars Schneider Date: Sat, 15 Oct 2016 14:47:26 GMT Subject: Re: [PATCH v10 14/14] contrib/long-running-filter: add long running filter example Message-ID: In-Reply-To: <3bdfebab-aae9-3263-218e-c8ae394084fc@web.de> > On 08 Oct 2016, at 22:42, Torsten Bögershausen wrote: > > On 08.10.16 13:25, larsxschneider@gmail.com wrote: >> From: Lars Schneider >> >> Add a simple pass-thru filter as example implementation for the Git >> filter protocol version 2. See Documentation/gitattributes.txt, section >> "Filter Protocol" for more info. >> > > Nothing wrong with code in contrib. > I may have missed parts of the discussion, was there a good reason to > drop the test case completely? > >> When adding a new feature, make sure that you have new tests to show >> the feature triggers the new behavior when it should, and to show the >> feature does not trigger when it shouldn't. After any code change, make >> sure that the entire test suite passes. > > Or is there a plan to add them later ? The test is part of the "main feature patch" 13/14: http://public-inbox.org/git/20161008112530.15506-14-larsxschneider@gmail.com/ Cheers, Lars