From: Lars Schneider <larsxschneider@gmail.com>
Date: Fri, 05 Aug 2016 21:50:38 GMT
Subject: Re: [PATCH v4 07/12] run-command: add clean_on_exit_handler
Message-ID: <ECE58461-10CC-49C2-9BE7-DB80A6746F88@gmail.com>
In-Reply-To: <b14c6063-cef8-56b4-eb57-7ab8577ecf0a@web.de>


> On 05 Aug 2016, at 23:19, Torsten Bögershausen <tboegi@web.de> wrote:
> 
> On 2016-08-05 15.08, Lars Schneider wrote:
> 
> []
>> Yeah it could do that. But then the filter cannot do things like
>> modifying the index after the fact... however, that might be considered
>> nasty by the Git community anyways... I am thinking about dropping
>> this patch in the next roll as it is not strictly necessary for my
>> current use case.
> (Thanks Peff for helping me out with the EOF explanation)
> 
> I would say that a filter is a filter, and should do nothing else than filtering
> one file,
> (or a stream).
> When you want to modify the index, a hook may be your friend.

Agreed. I will remove that feature.

Thanks,
Lars