From: Lars Schneider Date: Tue, 15 Sep 2015 14:49:44 GMT Subject: Re: [PATCH v2 1/2] git-p4: add test case for "Translation of file content failed" error Message-ID: In-Reply-To: <55F7A12D.9020603@web.de> On 15 Sep 2015, at 06:40, Torsten Bögershausen wrote: > On 09/14/2015 06:55 PM, larsxschneider@gmail.com wrote: >> From: Lars Schneider >> >> A P4 repository can get into a state where it contains a file with >> type UTF-16 that does not contain a valid UTF-16 BOM. If git-p4 >> attempts to retrieve the file then the process crashes with a >> "Translation of file content failed" error. >> >> Signed-off-by: Lars Schneider >> --- >> t/t9824-git-p4-handle-utf16-without-bom.sh | 47 ++++++++++++++++++++++++++++++ >> 1 file changed, 47 insertions(+) >> create mode 100755 t/t9824-git-p4-handle-utf16-without-bom.sh >> >> diff --git a/t/t9824-git-p4-handle-utf16-without-bom.sh b/t/t9824-git-p4-handle-utf16-without-bom.sh >> new file mode 100755 >> index 0000000..fa8043b >> --- /dev/null >> +++ b/t/t9824-git-p4-handle-utf16-without-bom.sh >> @@ -0,0 +1,47 @@ >> +#!/bin/sh >> + >> +test_description='git p4 handle UTF-16 without BOM' >> + >> +. ./lib-git-p4.sh >> + >> +UTF16="\\x97\\x0\\x97\\x0" >> + >> +test_expect_success 'start p4d' ' >> + start_p4d >> +' >> + >> +test_expect_success 'init depot with UTF-16 encoded file and artificially remove BOM' ' >> + ( >> + cd "$cli" && >> + echo "file1 -text" > .gitattributes && > Please no space between '>' and the filename, > (this is our coding standard, and the same further down) Correct! Sorry, I still need to get used to this style. Thanks for the reminder! > >> + perl -e "printf \"$UTF16\"" >file1 && > Ehh, do we need perl here ? > This will invoke a process-fork, which costs time and cpu load. > The following works for me: > printf '\227\000\227\000' >file1 I agree this is better. Both issues will be fixed v3. Thanks!