From: Alex Scarborough <alexsc@garagegames.com>
Date: Sat, 25 Jul 2009 06:41:59 GMT
Subject: Re: [PATCH] git init: optionally allow a directory argument
Message-ID: <EA5BDEF8-BACD-49FD-8AE9-D76D87DCFA40@garagegames.com>
In-Reply-To: <7vab2t64cg.fsf@alter.siamese.dyndns.org>


On Jul 24, 2009, at 4:36 PM, Junio C Hamano wrote:

> Nanako Shiraishi <nanako3@lavabit.com> writes:
>
>> When starting a new repository, I see my students often say
>>
>>    % git init newrepo
>>
>> and curse git.  They could say
>>
>>    % mkdir newrepo; cd newrepo; git init
>>
>> but allowing it as an obvious short-cut may be nicer.
>>
>> Signed-off-by: Nanako Shiraishi <nanako3@lavabit.com>
>
> Hmm, I didn't realize this is so common a wish among new people.
>
> The patch seems clean.  Anybody has comments, both on code and the use
> case?

The use case makes sense.  This helps make git init be a bit more  
consistent
with git clone, which can take a trailing target.

For the code, I would replace the direct use of mkdir with  
safe_create_dir.
Otherwise it looks fine.

-Alex Scarborough