From: Michael Witten <mfwitten@mit.edu>
Date: Fri, 01 Feb 2008 23:42:30 GMT
Subject: Re: [PATCH] git-send-email: ssh/login style password requests
Message-ID: <E83D03C8-5D96-4110-A047-B7B5F7582F3B@MIT.EDU>
In-Reply-To: <7v4pcs8d4z.fsf@gitster.siamese.dyndns.org>


On 1 Feb 2008, at 6:34 PM, Junio C Hamano wrote:

> Michael Witten <mfwitten@MIT.EDU> writes:
>
>> It turns out that --compose will also leave some temporary files
>> behind if git-send-email is terminated out of course.
>>
>> Should I establish a general handler for SIGTERM and SIGINT?
>
> I was mostly worried about ^C leaving the terminal in a funny
> state with your system(stty).
>
> I do not think you should lose the message the user carefully
> composed using an editor upon seeing ^C.  The user may start to
> compose, edit the message, and then at some later time decide to
> stop the mail-sending procedure by ^C-ing out.  The user would
> thank you if you somehow left an escape hatch to allow salvaging
> the message, instead of having it to be re-typed from scratch.

Indeed. How about a message stating that these files exist?

In any case, I'm looking for your endorsement of a signal handler
as the means to solve the main problem.