From: Matthias Lederhofer Date: Fri, 14 Jul 2006 16:37:06 GMT Subject: [PATCH] argv created by handle_alias should be NULL terminated Message-ID: Signed-off-by: Matthias Lederhofer --- Example: % git repo-config alias.test am % git test error: cannot open mbox JÜ·JÜ·JÜ·JÜ· JÜ· JÜ·(JÜ·(JÜ [..] --- git.c | 11 +++++------ 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/git.c b/git.c index 102735a..ee5a0e8 100644 --- a/git.c +++ b/git.c @@ -133,13 +133,12 @@ static int handle_alias(int *argcp, cons fflush(stderr); } + new_argv = realloc(new_argv, sizeof(char*) * + (count + *argcp + 1)); /* insert after command name */ - if (*argcp > 1) { - new_argv = realloc(new_argv, sizeof(char*) * - (count + *argcp)); - memcpy(new_argv + count, *argv + 1, - sizeof(char*) * *argcp); - } + memcpy(new_argv + count, *argv + 1, + sizeof(char*) * *argcp); + new_argv[count+*argcp] = NULL; *argv = new_argv; *argcp += count - 1; -- 1.4.1.g8b4b