From: Matt Hunter Date: Tue, 20 Oct 2026 09:13:07 GMT Subject: Re: [PATCH] init: show absolute path of (re)initialized repository Message-ID: In-Reply-To: On Tue Oct 20, 2026 at 2:55 AM EDT, Patrick Steinhardt wrote: > On Tue, Oct 20, 2026 at 01:38:47AM -0400, Matt Hunter wrote: >> >> None of the discussion [1] around the original patch indicates that this >> change was intentional, so address the regression by similarly using >> repo_get_git_dir in this code's new location. > > This indeed wasn't an intentional change. I also confirmed that with > v2.55 we print the full path. And with 2.56 :-) Output changed right at the beginning of this release cycle. > >> In this case, git_dir is referencing owned memory that is later freed, >> so declare a new variable to hold the used string. > > This sentence doesn't add any value as it simply explains parts that are > obvious when reading the patch. I'd just drop it. Yeah.. Will do > >> + int len = strlen(full_git_dir); > > I was wondering whether we want to fix the variable type to be a > `size_t` while at it. But maybe we should just keep it as-is. It's not of consequence to this change, but I agree it would be more correct. I'll include it. > > I'm a bit on the fence about whether we want to have a regression test > or not. It feels like a very specific thing in the user-facing output, > so it's a bit dubious whether it's really worth it. This is my thought exactly. > But on the other > hand, folks like you seem to care enough to make the test worthwhile, so > maybe we should have one? I could be convinced to add one. I'll see if additional feedback comes in before sending a new revision, but won't plan for a test as of now. Thanks for the review > > Thanks! > > Patrick