From: Ignacio Encinas <ignacio@iencinas.com>
Date: Tue, 29 Sep 2026 12:14:34 GMT
Subject: Re: hostname: includeIf condition — anyone already working on this?
Message-ID: <DLRSIZ3JV2DF.10GG1YB2D8DHW@iencinas.com>
In-Reply-To: <20260929014415.GB1089022@coredump.intra.peff.net>

Hello,

On Tue Sep 29, 2026 at 2:44 AM IST, Jeff King wrote:
> On Mon, Sep 28, 2026 at 08:43:49PM -0300, Isabella Caselli wrote:
>
>> - Any objection to the approach itself? The same machine can report
>> its hostname differently depending on how it's set up — sometimes just
>> the short name, sometimes with the full network address attached to it
>> — so it isn't obvious whether the condition should compare that value
>> exactly as the system reports it, or normalize it somehow before
>> comparing.
>
> Yes, that is the tricky part. :) There were some patches in 2024:
>
>   https://lore.kernel.org/git/20240307205006.467443-1-ignacio@iencinas.com/
>
> where the issue came up. Based on my recollection and a quick skim of
> the thread, I think the consensus was that it's OK to document that it
> is system-dependent whether we'll match against a short of fully
> qualified hostname. But exposing our view of the hostname via git-var
> (e.g., "git var GIT_HOSTNAME") might be a helpful debugging aid.
>
> It looks like after review on v3 of the series we never saw more. I'd
> guess the author (cc'd) just never got around to pushing it forward.

That's what happened. Similar to Isabella, I was looking for a small
contribution but it ended up being more complicated than expected. I got
a bit overwhelmed and decided to drop it.

I kept wondering if I should have communicated that, so apologies if
that was the case.

I hope the discussion from 2024 is at least helpful now if this ends up
being implemented by Isabella.

Best regards,
Ignacio