From: Andreas Färber <andreas.faerber@web.de>
Date: Sun, 07 Jun 2009 12:49:16 GMT
Subject: Re: mkstemps compat issue
Message-ID: <DAD17464-336A-451A-AEFE-26481D6B39B2@web.de>
In-Reply-To: <ED882BBA-E0E7-4CCC-9C6B-72FEBED1C9E0@web.de>


Am 07.06.2009 um 14:32 schrieb Andreas Färber:

> The merge commit b11cf09043f18b368ec0d988f064ea21247c843d introduced  
> a git_mkstemps function in path.c, using mkstemps for the  
> implementation. Unlike mkstemp that function is not part of POSIX,  
> so we seem to need a NO_MKSTEMPS option and corresponding  
> alternative code path.
>
> Any suggestions how to best replace mkstemps?

Sorry for the noise... NO_MKSTEMPS=YesPlease does work correctly if  
typed correctly. (Thanks for the hint!)

It was a little confusing seeing mkstemps being used unconditionally  
in path.c, but it's being #defined in git-compat-util.h, so everything  
is fine.

Regards,

Andreas