From: Joshua Juran Date: Tue, 10 Aug 2010 22:34:17 GMT Subject: Re: [PATCH] More readable 'Not a git repository' messages Message-ID: In-Reply-To: <20100810155240.GA5116@localhost.localdomain> On Aug 10, 2010, at 8:52 AM, Jared Hance wrote: > On Mon, Aug 09, 2010 at 07:24:35PM +0200, Ralf Ebert wrote: >> old: Not a git repository (or any of the parent directories): .git >> new: Not in a git repository: /home/bob/somefolder > > Don't we lose information here? Perhaps print the value of > DEFAULT_GIT_DIR_ENVIRONMENT. > >> old: Not a git repository (or any parent up to mount parent /home/ >> bob) >> old: Stopping at filesystem boundary >> (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). >> new: Not in a git repository: /home/bob/somefolder >> new: (stopped searching at /home because >> GIT_DISCOVERY_ACROSS_FILESYSTEM is not set) > > This certainly looks good, but some people might not realize /home is > a filesystem boundary (perhaps those who had someone else set up their > system and don't know their partition setup. I suggest: > > (stopped searching at the filesystem boundary, /home, because > GIT_DISCOVERY_ACROSS_FILESYSTEM is not set) If the search for .git stops at /home or $HOME, why not say nothing at all? If you've turned /home (or /) into a Git repo, then either you know what you're doing or you deserve as much pain as possible. (I haven't decided which.) Josh