From: David Rydh <dary@math.berkeley.edu>
Date: Fri, 22 Jan 2010 16:49:08 GMT
Subject: Re: [PATCH] git-mv: Fix error with multiple sources.
Message-ID: <D7FDF1CC-CED4-4CE8-9FEC-6A630830504C@math.berkeley.edu>
In-Reply-To: <7vhbqeacjm.fsf@alter.siamese.dyndns.org>


On Jan 21, 2010, at 10:17 PM, Junio C Hamano wrote:

> "David Rydh" <dary@math.berkeley.edu> writes:
> 
>> This commit also fixed two potentially dangerous uses of
>> prefix_filename() -- which returns static storage space -- in
>> builtin-config.c and hash-object.c.
> 
> This should probably be a separate patch.  builtin-hash-object.c also uses
> prefix_filename() first to obtain vpath without strdup() and then uses the
> function to create arg, which seems to be unsafe to me.  I've looked at
> all the hits from 
> 
>    $ git grep -n -e prefix_filename\( -- '*.c'
> 
> and other places seem to be Ok.


Yes, this was how I found these two places. Do you agree that strdup'ing vpath as I did in the patch fixes this flaw? (I assume that builtin-hash-object.c = hash-object.c) I'll split it up into two patches.