From: Michael Witten Date: Sat, 27 Sep 2008 01:13:44 GMT Subject: Re: [PATCH RFC 4/6] Docs: send-email: Option order the same in man page and usage text Message-ID: In-Reply-To: <20080926224032.GA24817@coredump.intra.peff.net> On 26 Sep 2008, at 5:40 PM, Jeff King wrote: > I think overall this serious is well-intentioned the results look sane > to me (I diffed the manpage and usage text before and after). > > My only concerns are: > > 4/6: ... > The manpage, on the other hand, is a comprehensive reference and > so should probably be alphabetized for easy reading. I can buy it. I'll change it back. > ... > That being said, I find the length of the current usage > statement > somewhat ridiculous. I'll take care of it. > 5/6: This isn't really a documentation patch, as it adds a new config > option. I think the result is reasonable, but it was a surprise > after reading the rest of the series. I didn't mean to mark those as Docs. I'll fix that too. > I was also going to complain that there was no entry in > Documentation/config.txt for the new option, but I see that none > of the sendemail options are there. Maybe while you are working > on this, it is worth factoring them out to send-email- > options.txt > and including it in both git-send-email.txt and config.txt. Grumble grumble grumble... erm.. hmm.. grrr.. ok.