From: Bence Ferdinandy <bence@ferdinandy.com>
Date: Sun, 05 Jan 2025 15:13:32 GMT
Subject: Re: [PATCH v3 2/3] fetch set_head: add warn-if-not-$branch option
Message-ID: <D6U8JPC18M31.3N0PIVKB8XTLG@ferdinandy.com>
In-Reply-To: <20250105114201.35079-1-tenglong.tl@alibaba-inc.com>


On Sun Jan 05, 2025 at 12:42, Teng Long <dyroneteng@gmail.com> wrote:
>
> Bence Ferdinandy <bence@ferdinandy.com> wrote:
>
>> @@ -1584,10 +1584,12 @@ static void set_head_advice_msg(const char *remote, const char *head_name)
>>  	const char message_advice_set_head[] =
>>  	N_("Run 'git remote set-head %s %s' to follow the change, or set\n"
>>  	   "'remote.%s.followRemoteHEAD' configuration option to a different value\n"
>> -	   "if you do not want to see this message.");
>> +	   "if you do not want to see this message. Specifically running\n"
>> +	   "'git config set remote.%s.followRemoteHEAD %s' will disable the warning\n"
>> +	   "until the remote changes HEAD to something else.");
>> 
>>  	advise_if_enabled(ADVICE_FETCH_SET_HEAD_WARN, _(message_advice_set_head),
>> -			remote, head_name, remote);
>> +			remote, head_name, remote, remote, head_name);
>> 
>
> Seems like the config is unsupported to be feed a variable named "head_name"?
>
> Thanks.

Ah, yes the warning seems to be off, it should read

git config set remote.%s.followRemoteHEAD warn-if-not-%s

thanks for catching this mistake!

Best,
Bence