From: Bence Ferdinandy <bence@ferdinandy.com>
Date: Thu, 05 Dec 2024 08:14:00 GMT
Subject: Re: [PATCH v2 3/3] remote set-head: set followRemoteHEAD to "warn" if "always"
Message-ID: <D63M7LIBTL4B.EXTQ3OSFM9XO@ferdinandy.com>
In-Reply-To: <173ea521-6a2e-45aa-ae5e-4da99060cc4f@app.fastmail.com>


On Wed Dec 04, 2024 at 21:44, Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com> wrote:
> On Wed, Dec 4, 2024, at 21:40, Junio C Hamano wrote:
>> "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
>>
>>> On Wed, Dec 4, 2024, at 11:39, Bence Ferdinandy wrote:
>>>> diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh
>>>> index 7411aa770d..daf70406be 100755
>>>> --- a/t/t5505-remote.sh
>>>> +++ b/t/t5505-remote.sh
>>>> @@ -504,6 +504,17 @@ test_expect_success 'set-head --auto has no
>>>> problem w/multiple HEADs' '
>>>>  	)
>>>>  '
>>>>
>>>> +test_expect_success 'set-head changes followRemoteHEAD always to warn' '
>>>> +	(
>>>> +		cd test &&
>>>
>>> I think you need to `cd` in a subshell here.  See `t/README`, “Don't
>>> chdir around in tests.”.
>>
>> Puzzled.  Isn't this inside a (subshell) already?
>
> Aha, then I didn’t read the context properly.

Thanks for the review! What I gathered is that v3 needs an s/output/actual and
we're good. I'll send that soonish.

Thanks,
Bence