From: Bence Ferdinandy <bence@ferdinandy.com>
Date: Tue, 15 Oct 2024 16:17:26 GMT
Subject: Re: [PATCH v6 3/6] set-head: better output for --auto
Message-ID: <D4WIJYJHI6MX.1GVDAHVOLKGO7@ferdinandy.com>
In-Reply-To: <65dd8e08-d8b2-4abb-a141-002d8f0b0401@gmail.com>


On Tue Oct 15, 2024 at 16:10, Phillip Wood <phillip.wood123@gmail.com> wrote:
> On 15/10/2024 08:51, karthik nayak wrote:
>> "Bence Ferdinandy" <bence@ferdinandy.com> writes:
>>> On Fri Oct 11, 2024 at 22:43, karthik nayak <karthik.188@gmail.com> wrote:
>> 
>> I'm not sure I entirely agree with this sentiment. Consistency is a
>> great goal to target, but it shouldn't hinder changes that are
>> beneficial.
>
> Exactly - if we wait for an entire test file to be modernized before 
> using our modern test idioms in it we'll be waiting forever. It is much 
> better to introduce the use of things like ${SQ} that improve 
> readability as we add new tests or modify existing ones.

Ok, I'll change the patch to use SQ. As I gather, it would be preferred if
_all_ the tests would use ${SQ}? If this patch series is finally resolved I can
send a patch for this style change, shouldn't be too complicated.