From: Bence Ferdinandy <bence@ferdinandy.com>
Date: Sat, 21 Sep 2024 22:19:43 GMT
Subject: Re: [PATCH v3 1/2] update_symref: add REF_CREATE_ONLY option
Message-ID: <D4CB89OCTXWW.2A4NL7RQP4IS@ferdinandy.com>
In-Reply-To: <7fecc442-8d5e-4542-8ce8-907c35db870d@gmail.com>


On Sat Sep 21, 2024 at 15:40, Phillip Wood <phillip.wood123@gmail.com> wrote:
> On 19/09/2024 13:13, Bence Ferdinandy wrote:
> > Add a new REF_CREATE_ONLY flag for use by the files backend which will
> > only update the symref if it doesn't already exist. Add the possibility
> > to pass extra flags to refs_update_symref so that it can utilize this
> > new flag.
>
> I'm not sure we need a new flag to do this as it is already supported by
> the ref transaction api.

Thanks, I was not aware of ref_transaction_create. It also seems to return with
TRANSACTION_NAME_CONFLICT so we should be able to see from the error code if
indeed the existence was the problem or something else went wrong.

Best,
Bence