From: James Liu <james@jamesliu.io>
Date: Sun, 05 May 2024 23:17:21 GMT
Subject: Re: [PATCH v4 0/3] advice: add "all" option to disable all hints
Message-ID: <D123EO5XLSAG.1DARNM0DT2Z74@jamesliu.io>
In-Reply-To: <CAOLa=ZSHPVbd2pweNz+MtkdWgsZepsExODyd7UNx1774TzWV0A@mail.gmail.com>

On Sat May 4, 2024 at 12:35 AM AEST, Karthik Nayak wrote:
> Hello James,
>
> James Liu <james@jamesliu.io> writes:
>
> > Hi,
> >
> > Thank you all for the comprehensive feedback. This is v4 of the patch
> > series to introduce a --no-advice option for silencing advice hints.
> >
> > The main changes are:
> >
> > - Two preliminary commits to reorder/clean up the options documentation
> >   and usage string.
> > - Caching the value of GIT_ADVICE.
> > - Adding tests which explicitly set GIT_ADVICE to false and true.
> >
> > Cheers,
> > James
> >
>
> This version looks good to me.
>
> Thanks
> Karthik
>

Thanks for the review Karthik!

Cheers,
James