From: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Date: Mon, 08 Jun 2026 22:40:25 GMT
Subject: Re: [GSoC PATCH v2 4/4] repo: add path.commondir with absolute and relative suffix formatting
Message-ID: <D0CF1CC0-DF1A-482A-AD1D-D41680A1672D@gmail.com>
In-Reply-To: <20260605163012.181089-5-jayatheerthkulkarni2005@gmail.com>

This patch looks really straightforward after the previous one.
I hope the rest of the path.* series will be just like that.

> +test_repo_info_path 'commondir' 'echo "$(cd .. && pwd)/.git"' '../.git'
> +test_repo_info_path 'commondir' 'echo "$(cd .. && pwd)/custom-common"' '../custom-common' 'GIT_COMMON_DIR="$(cd .. && pwd)/custom-common" GIT_DIR=../.git'
> +test_repo_info_path 'commondir' 'echo "$(cd .. && pwd)/.git"' '../.git' 'GIT_DIR=../.git'

If you use the test_repo_info_path that I suggested in the
other answer, this would be:

test_repo_info_path 'commondir without env vars' 'commondir' 'common-no-env' \
                    '.git' '../.git'

test_repo_info_path 'commondir with GIT_COMMON_DIR and GIT_DIR' 'commondir' \
                    'commondir-envs' 'custom-common' '../custom-common'\
		    'export GIT_COMMON_DIR="$ROOT/custom-common" &&
		     export GIT_DIR="../.git" &&
		     git init --bare "$ROOT/custom-common"
		    '

test_repo_info_path 'commondir with only GIT_DIR' 'commondir' \
                    'commondir-only-gitdir' '.git' '../.git' 'GIT_DIR=../.git'