From: James Liu <james@jamesliu.io>
Date: Wed, 28 Feb 2024 00:13:49 GMT
Subject: Re: [PATCH 11/12] reftable/record: decode keys in place
Message-ID: <CZGA0UX31LAO.1QWOAGQ6BUKIS@jamesliu.io>
In-Reply-To: <f0663c1d62d13d01afb1fa6c3760a38741bdfc8e.1707895758.git.ps@pks.im>

On Wed Feb 14, 2024 at 6:46 PM AEDT, Patrick Steinhardt wrote:
> -	strbuf_reset(key);
> -	strbuf_add(key, last_key.buf, prefix_len);
> -	strbuf_add(key, in.buf, suffix_len);
> +	strbuf_setlen(last_key, prefix_len);
> +	strbuf_add(last_key, in.buf, suffix_len);
>  	string_view_consume(&in, suffix_len);
>  
>  	return start_len - in.len;

Since we're using `strbuf`, there's no need to worry about extra bytes
for the null terminator here right?