From: Ghanshyam Thakkar <shyamthakkar001@gmail.com>
Date: Fri, 02 Feb 2024 17:53:01 GMT
Subject: Re: [PATCH v2 2/2] add-patch: classify '@' as a synonym for 'HEAD'
Message-ID: <CYUS9OD6A01I.1IQC872DESCQ0@gmail.com>
In-Reply-To: <xmqqv876sqwf.fsf@gitster.g>

On Fri Feb 2, 2024 at 11:13 PM IST, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
> > You decided to use is_rev_head() instead of user_meant_head(), so
> > you'd need to update the above description to match, I think.
>
> Having said this, I have a slight fear that normal users would
> expect is_rev_head(X) to say "yes" for "master" when the current
> branch is "master", though.  is_head(X) would have the same
> downside.
Yeah, user_meant_head() looks like the better pick. I'll update it.