From: Steffen Prohaska Date: Sun, 20 May 2007 20:38:23 GMT Subject: Re: [PATCH] rev-list: '--indent' oneline output Message-ID: In-Reply-To: <7vveenl4u4.fsf@assigned-by-dhcp.cox.net> On May 20, 2007, at 8:36 PM, Junio C Hamano wrote: > Steffen Prohaska writes: > >> Summaries in oneline output are indented to show the location of >> parents in merge commits. Indentation level is computed as the >> smallest sum of parent locations along all paths that reach the >> commit. >> >> As a result, the output of >> git-rev-list --pretty=oneline --topo-order --indent >> is formatted in a way that resembles merge summaries. All commits >> that >> were pulled from a branch are indented with one additional space >> below >> the summary of the merge commit. > > I would have expected this kind of UI level tweak to be done not > as a rev-list feature, but the subject of the e-mail to read > something like "--pretty=oneline: allow indentation levels", > i.e. wouldn't the feature apply not just rev-list but also > git-log? It's only a proof of concept. I do not expect to see it added in the current form. I'm not yet convinced if it's really a useful feature. I'm also not sure if changing 'struct commit' is a good idea. gitk is able to display the commit graph by parsing output of the existing git-rev-list. It should be possible to do similar for log formatting without changing 'struct commit'. - Steffen