From: Ed Maste <emaste@freebsd.org>
Date: Wed, 26 Feb 2020 20:20:44 GMT
Subject: Re: [PATCH 1/3] t/lib-httpd: avoid using BSD's sed
Message-ID: <CAPyFy2ArnEFe33GFLsbcOEV37DZ=VJpF-Sckn-V_tJUrToir=w@mail.gmail.com>
In-Reply-To: <9900cacbfefb46610114702e6d48d8020f3f2866.1582747775.git.gitgitgadget@gmail.com>

On Wed, 26 Feb 2020 at 15:09, Johannes Schindelin via GitGitGadget
<gitgitgadget@gmail.com> wrote:
>
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> Among other differences relative to GNU sed, BSD sed always ends its
> output with a trailing newline, even if the input did not have such a
> trailing newline.
>
> Surprisingly, this makes three httpd-based tests fail on macOS: t5616,
> t5702 and t5703. ("Surprisingly" because those tests have been around
> for some time, but apparently nobody runs them on macOS with a working
> Apache2 setup.)

Hmm, this is interesting - all tests (that are executed) are passing
on FreeBSD, in CI.

I tried on FreeBSD and do not see a trailing newline added; I'm not
sure how sed behaves on other BSDs. However, you probably want to
refer to macOS sed rather than BSD sed in the commit.