From: Chris Torek Date: Fri, 14 Apr 2023 02:08:23 GMT Subject: Re: [PATCH 5/5] banned.h: mark `strtok()`, `strtok_r()` as banned Message-ID: In-Reply-To: On Thu, Apr 13, 2023 at 7:00 PM Junio C Hamano wrote: > ... At best, they may point out awkwardness of the function [strtok_r] The awkward interface for strtok as extended to strtok_r is why we (Keith Bostic and I) came up with what's now strsep. Of course strsep is not standard and has its own issues but it can be used to parse $PATH for instance, or old-style /etc/passwd entries. In this case (tests) it's probably not that important to be efficient anyway, Chris