From: Chris Torek <chris.torek@gmail.com>
Date: Wed, 29 Jul 2020 21:03:08 GMT
Subject: Re: [PATCH v2 0/7] making log --first-parent imply -m
Message-ID: <CAPx1GvesMkZfgVDNQcHHOWHmVTOrEnpbJB5WOqZwG14m2RCEiA@mail.gmail.com>
In-Reply-To: <20200729201002.GA2989059@coredump.intra.peff.net>

On Wed, Jul 29, 2020 at 1:10 PM Jeff King <peff@peff.net> wrote:
> Here's a re-roll taking into account the discussion so far:
>
>   - the escape hatch option name is flipped to "--no-diff-merges" (with
>     "--diff-merges" matching "-m")
>
>   - the documentation now discusses the change as well as the existing
>     handling of merges; this involved a few extra cleanups. Try
>     "doc-diff" for a better view of the actual rendered changes.
>
>     I do think longer term we'd be better off to stop having this maze
>     of ifdef'd inclusions, and just have gitdiff(7) which covers all of
>     the possibilities in human-readable text (so yes, you might see a
>     mention of diff-files while you're looking for info on git-log, but
>     that would also broaden your mind about how the different commands
>     work). But that's clearly outside the scope of this series. I think
>     what's here is a strict improvement.

I agree.  The new series looks good.

Chris