From: Chris Torek <chris.torek@gmail.com>
Date: Thu, 21 Jan 2021 12:53:15 GMT
Subject: Re: [PATCH 3/9] fsmonitor: de-duplicate BUG()s around dirty bits
Message-ID: <CAPx1GveERs+g6zymyc8AbVudRHz24=N-1WZg+1xj5j1z0prWyg@mail.gmail.com>
In-Reply-To: <838922de2e9756c00f4a159b2b8722ae4d28b011.1611161639.git.gitgitgadget@gmail.com>

On Wed, Jan 20, 2021 at 8:58 AM Derrick Stolee via GitGitGadget
<gitgitgadget@gmail.com> wrote:
>
> From: Derrick Stolee <dstolee@microsoft.com>
>
> The index has an fsmonitor_dirty bitmap that records which index entries
> are "dirty" based on the response from the FSMonitor. If this bitmap
> ever grows larger than the index, then there was an error in how it was
> constructed, and it was probably a developer's bug.

Curious: some of the tests were >=, some were > (not >=).  Now
that they're shared in a function they are all ">".

It's pretty clear that for size-based ones, greater-than is the
right test, but for position ones, isn't it still greater-or-equal?  So
perhaps the calls that pass an actual position should add 1...

Chris