From: Chris Torek Date: Mon, 24 Apr 2023 22:25:55 GMT Subject: Re: [PATCH v3 6/6] banned.h: mark `strtok()` and `strtok_r()` as banned Message-ID: In-Reply-To: I eyeballed the whole thing (not the same as real tests of course) and it looks good, but there's one typo (missing-word-o) here of note: On Mon, Apr 24, 2023 at 3:20 PM Taylor Blau wrote: ... > But there are no instances of this in Git's tree which are more > well-suited to `strtok_r()` than the friendlier > `string_list_in_place()`, so ban `strtok_r()`, too. > > Signed-off-by: Taylor Blau Missing `split_`. Probably not worth a re-roll... Chris