From: Chris Torek <chris.torek@gmail.com>
Date: Sun, 23 Mar 2025 01:11:51 GMT
Subject: Re: [PATCH v2] shell: allow overriding built-in commands
Message-ID: <CAPx1Gvd+0XBVm6N6Vrogczhqy8hARajoQ+zDgaaeKMTcSskmeA@mail.gmail.com>
In-Reply-To: <pull.1930.v2.git.git.1742688740650.gitgitgadget@gmail.com>

I'm not at all sure about any security implications, but aside from that, I
suspect this:

On Sat, Mar 22, 2025 at 5:13 PM Ayman Bagabas via GitGitGadget
<gitgitgadget@gmail.com> wrote:
> +               if (!access(full_cmd, F_OK)) {

should use X_OK rather than F_OK.

Chris