From: Chris Torek <chris.torek@gmail.com>
Date: Fri, 05 Feb 2021 10:59:06 GMT
Subject: Re: [PATCH v2 15/17] midx: use 64-bit multiplication for chunk sizes
Message-ID: <CAPx1GvcNTkXo-6rdaRc4YNGAq8AoCtwT86AEUT+A6c22erVW0g@mail.gmail.com>
In-Reply-To: <xmqq8s834c4s.fsf@gitster.c.googlers.com>

On Thu, Feb 4, 2021 at 4:00 PM Junio C Hamano <gitster@pobox.com> wrote:
>  * the fourth parameter of add_chunk() is of size_t, not uint64_t;
>    shouldn't the multiplication be done in type size_t instead?

There are (still) systems with 32-bit size_t (but 64-bit
off_t / file sizes), so ... probably not.  Is size_t ever more than
64 bits these days?

Chris