From: Stepan Koltsov <stepan.koltsov@jetbrains.com>
Date: Fri, 18 May 2012 22:26:08 GMT
Subject: Re: bugreport: stgit cannot export empty patch
Message-ID: <CAPk5vtyc1gHB=31CPDpk=s4QE+Wtp-8wMJDuV1F=R11MfERdTw@mail.gmail.com>
In-Reply-To: <xmqqboll2nl0.fsf@junio.mtv.corp.google.com>

On Sat, May 19, 2012 at 1:20 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Stepan Koltsov <stepan.koltsov@jetbrains.com> writes:
>
>> stgit fails to export empty patches:
>>
>> % stg new empty-patch -m 'asasas'
>> Now at patch "empty-patch"
>> % stg export empty-patch
>> Checking for changes in the working directory ... done
>> fatal: unrecognized input
>> stg export: git failed with code 128
>> zsh: exit 2     stg export empty-patch
>>
>> % stg --version
>> Stacked GIT 0.16-3-g67cf
>> git version 1.7.9.1
>> Python version 2.7.1 (r271:86832, Jul 31 2011, 19:30:53)
>> [GCC 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2335.15.00)]
>
> I don't use (or read the sources to) StGIT, but isn't the whole point of
> "stg export" to "convert your StGIT patches into patch files"?  For an
> empty commit, what is an appropriate output?  IOW, is it reasonable to
> have an empty commit in your history if you are planning to "stg export"
> it?

I'm executing stg export to back up. If series contains empty patches,
backup fails.

Scenario: I started some work, created new empty patch, but did
nothing, decided to go home, and do backup of the whole series before
leaving. Backup fails.

AFAIU there's no simpler way to backup stg series than executing

% stg export `stg series --noprefix`

-- 
Stepa