From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 28 Jul 2022 21:09:38 GMT
Subject: Re: [PATCH] format-patch: clarify --creation-factor=<factor>
Message-ID: <CAPig+cTxM2vr11XRU-zrNAJRwveP0W9d0x8Euvr6HKmQicKgPQ@mail.gmail.com>
In-Reply-To: <xmqqv8rh9co5.fsf@gitster.g>

On Thu, Jul 28, 2022 at 4:59 PM Junio C Hamano <gitster@pobox.com> wrote:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> >> diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt
> >> @@ -27,7 +27,7 @@ SYNOPSIS
> >> -               [--range-diff=<previous> [--creation-factor=<percent>]]
> >> +               [--range-diff=<previous> [--creation-factor=<factor>]]
> >> @@ -321,7 +321,7 @@ product of `format-patch` is generated, and they are not passed to
> >> ---creation-factor=<percent>::
> >> +--creation-factor=<factor>::
> >
> > Looks good as far as it goes, looks like both of your patches need to
> > also tweak this bit though:
> >
> >       $ git -P grep 'percentage.*creation' -- '*.c'
> >       builtin/log.c:                      N_("percentage by which creation is weighted")),
> >       builtin/range-diff.c:                       N_("percentage by which creation is weighted")),
> >
> > Probably just s/percentage/factor/ in for those -h strings?
>
> Thanks for being extra careful.
>
> Eric, I am not sure if the other patch for the range-diff command as
> a standalone patch is worth it.  Perhaps you can help me by
> submitting a single combined patch to cover the above as well as
> what we wrote in the two patches, with you marked as the primary
> author and with Helped-by: that credits Ævar?

Will do.

(Slightly chagrined that I forgot to check the usage-string in the C
files. Thanks, Ævar.)