From: Eric Sunshine <sunshine@sunshineco.com>
Date: Thu, 09 Jul 2015 22:55:08 GMT
Subject: Re: [PATCH v2 9/9] diffcore-pickaxe: support case insensitive match on non-ascii
Message-ID: <CAPig+cTuTAHWwPDrbpOovN6HBvZRKHLGM-FPpEU3ZxXpH-aSCw@mail.gmail.com>
In-Reply-To: <1436351919-2520-10-git-send-email-pclouds@gmail.com>

On Wed, Jul 8, 2015 at 6:38 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> Similar to the "grep -F -i" case, we can't use kws on icase search
> outside ascii range, quote we quote the string and pass it to regcomp

s/quote we quote/so we quote/

(or something)

> as a basic regexp and let regex engine deal with case sensitivity.
>
> The new test is put in t7812 instead of t4209-log-pickaxe because
> lib-gettext.sh might cause problems elsewhere, probably..
>
> Noticed-by: Plamen Totev <plamen.totev@abv.bg>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>