From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 15 Dec 2025 17:51:50 GMT
Subject: Re: meson -Drust=enabled fails on macOS without GNU sed
Message-ID: <CAPig+cTrLkEPGb=7dU1pnB9ir+vMaJ2W=J3R6+9kLuHkubtS_g@mail.gmail.com>
In-Reply-To: <aUApKxjYHMPHNIac@pks.im>

On Mon, Dec 15, 2025 at 10:28 AM Patrick Steinhardt <ps@pks.im> wrote:
> On Fri, Dec 12, 2025 at 03:32:30PM -0500, Eric Sunshine wrote:
> > On Fri, Dec 12, 2025 at 3:01 PM D. Ben Knoble
> > <ben.knoble+github@gmail.com> wrote:
> > > I think it's due to e509b5b8be (rust: support for Windows, 2025-10-15)
> > > [relevant folks CC'd], where we assume sed can take "-s" (which AFAICT
> > > is a GNU extension). But perhaps "-n" was intended with a "p" flag on
> > > the substitution?
> >
> > Yup, that's a strange one. Indeed:
> >
> >     sed -n 's/^host: \(.*\)$/\1/p'
> >
> > would be the correct way to do it, while also being compatible with
> > BSD-lineage `sed` (such as `sed` on macOS).
>
> Ah, indeed. Would one of you want to turn this into a patch?

I'm not likely to have the time, presently. Ben is welcome to attack
the task if he desires.