From: Eric Sunshine <sunshine@sunshineco.com>
Date: Wed, 13 Aug 2025 15:38:22 GMT
Subject: Re: [BUG] suppress-cc does not support multiple keywords
Message-ID: <CAPig+cTr2e6wQ79VXpADuL6UGVwtHu0qkTfFz7sBdwM_MYk6Ow@mail.gmail.com>
In-Reply-To: <xmqqfrdvp9zs.fsf@gitster.g>

On Wed, Aug 13, 2025 at 10:33 AM Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
> > ... If there is any "bug", it's that the documentation does state
> > that you can specify --suppress-cc multiple times (even though you
> > obviously can).
>
> "does state"?  or "does not state" or "does state that you cannot"?
>
> I guess you meant the second one

Indeed, I did mean the second one. Don't know how I dropped the word
"not". Sorry for any confusion, and thanks for the correction.

> The existing text
>         --suppress-cc=<category>::
>                 Specify an additional category of recipients to suppress the
>                 auto-cc of:
> does make it clear that <category> given to a single instance of
> this option is a single category ("AN additional category").
>
> Perhaps a minimum fix would be something like this?
>
> -Default is the value of `sendemail.suppressCc` configuration value; if
> +Can be given more than once to suppress multiple categories.
> +Default is the value of `sendemail.suppressCc` configuration
> +variable (which can be given multiple times, one category at a time); if
>  that is unspecified, default to `self` if `--suppress-from` is

Yes, I think that would be a welcome change.