From: Eric Sunshine <sunshine@sunshineco.com>
Date: Tue, 28 Aug 2018 20:17:00 GMT
Subject: Re: [PATCH v4 4/6] tests: use shorter here-docs in chainlint.sed for AIX sed
Message-ID: <CAPig+cTo402TVFpdrz5JPOrX7OhNNQCs6vGCP4LdQ8=a3dtgww@mail.gmail.com>
In-Reply-To: <87a7p6dza3.fsf@evledraar.gmail.com>

On Tue, Aug 28, 2018 at 4:14 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> On Fri, Aug 24 2018, Eric Sunshine wrote:
> > Shortening the names makes them ugly and often unreadable. That's not
> > a complaint with this patch; just a general observation regarding
> > 8-byte limitation with this platform's "sed" (and POSIX). See a few
> > suggested improvements below, but probably not worth a re-roll.
> >> +:clssolo
> > ":endsolo"
>
> I was meaning to get to this with a re-roll, but since this is already
> in next & these label renames seem cosmetic, it seems better to do this
> after 2.19, i.e. the compiler doesn't care about the specific names, but
> shortening them to <=8 fixes the bug.

Sounds fine. There's no rush. Thanks.